Conversation
|
There is a good reason why I made the FPU enabled by default. If you do disable it by default, you better give a big warning that people should compile the code with -mgeneral-regs-only, otherwise they'll get crashes. |
JDuchniewicz
force-pushed
the
jakub/fpu_flag
branch
2 times, most recently
from
efe6d3d to
95044b3
Compare
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
|
Yes. Now it's enabled by default. |
| affinity: Word(vcpu.cpu.0.into()), | ||
| prio: virtual_machine.priority, | ||
| max_prio: virtual_machine.priority, | ||
| fpu: true, |
There was a problem hiding this comment.
we should probably have a VM fpu attribute here too
There was a problem hiding this comment.
Very small chance anyone would want to disable the FPU for a VM though.
Also, this wouldn't work for x86, where the flag is used for the host task and the FPU is always enabled for the guest itself.
There was a problem hiding this comment.
As I understand it it will be refined at a later step during the system setup as mentioned below:
As discussed offline,
fpu: trueis fine here. As this function's purpose is to only create what can be inferred from just the ELF, while leaving everything else with reasonable defaults. Refining the TCB will happen at a later step in the caller atmicrokit/tool/microkit/src/capdl/builder.rs
Line 972 in 23f1f6d
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
| Must be be between 4KiB and 16MiB and be 4K page-aligned. Defaults to 8KiB. | ||
| * `cpu`: (optional) set the physical CPU core this PD will run on. Defaults to zero. | ||
| * `smc`: (optional, only on ARM) Allow the PD to give an SMC call for the kernel to perform.. Defaults to false. | ||
| * `fpu`: (optional) disable the FPU support for this PD. Defaults to true. |
There was a problem hiding this comment.
| * `fpu`: (optional) disable the FPU support for this PD. Defaults to true. | |
| * `fpu`: (optional) whether this PD can access the FPU. Defaults to true. |
|
Main issue is rust-sel4 PR, otherwise this is pretty trivial. For now I can merge the FPU changes into our rust-sel4 branch for development, but we'll need to merge that PR before the release. |
5 participants
In conjunction with seL4/rust-sel4#316 allows for using the
fpuflag to specify that a PD can be using the FPU.